Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden use of SearchValues in TryFindNextPossibleStartingPosition in Regex #89205

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Broaden use of SearchValues in TryFindNextPossibleStartingPosition in Regex #89205

merged 1 commit into from
Jul 20, 2023

Commits on Jul 19, 2023

  1. Broaden use of SearchValues in TryFindNextPossibleStartingPosition in… 

    … Regex

SearchValues has been updated to have an ASCII fast-path for inputs that are not only ASCII.  This means we can simplify TryFindNextPossibleStartingPosition in Regex to not track AsciiSet specially and instead just increase the number of characters we query the set for (from 5 to 128).  That way, we'll use SearchValues rather than emitting our own helper up until a (semi-arbitrary) point where we deem it impossible or infeasible to enumerate all the chars that make up the set.
    @stephentoub
    stephentoub committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    66e9711 View commit details
    Browse the repository at this point in the history