-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share SourceWriter between JSON & config binding generators #89150
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #88918. FYI @tannergooding @ericstj @jasper-d @martincostello @vcsjones @lateralusX. The writer used for the JSON generator has the correct right line-ending behavior.
|
b3162e0
to
65c718f
Compare
65c718f
to
9fd0a7a
Compare
...braries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/LineEndingsHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/LineEndingsHelper.cs
Outdated
Show resolved
Hide resolved
b1c8e64
to
5e37570
Compare
/backport to release/8.0-preview7 |
Started backporting to release/8.0-preview7: https://github.com/dotnet/runtime/actions/runs/5602367197 |
Shouldn't this be merged before initiating a backport PR? |
We're close on time -- it's fine to merge in parallel so long as we squash the commits in release. It does mean that both PRs need to be kept in sync, but right now we're ready to merge and just waiting for the validation build to complete. Assuming both are green we save a couple hours by doing it parallel. |
Build failure appears unrelated. |
Fixes #88918. FYI @tannergooding @ericstj @jasper-d @martincostello @vcsjones @lateralusX.
The writer used for the JSON generator has the correct right line-ending behavior.