Add NativeAOT runtime pack builds for osx x64/arm64 #89018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for the NativeAOT work in xamarin-macios
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThis is necessary for the NativeAOT work in xamarin-macios
|
lewing
approved these changes
Jul 17, 2023
steveisok
approved these changes
Jul 17, 2023
am11
reviewed
Jul 17, 2023
| @@ -104,6 +104,8 @@ extends: | |||
| jobTemplate: /eng/pipelines/common/global-build-job.yml | |||
| buildConfig: release | |||
| platforms: | |||
| - osx_x64 | |||
| - osx_arm64 | |||
There was a problem hiding this comment.
Do you know why win, linux and linux_musl are missing from this list?
There was a problem hiding this comment.
Tracked by #87060. It should be done, but one step at a time.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis is necessary for the NativeAOT work in xamarin-macios
|
This was referenced Jul 17, 2023
jkotas
approved these changes
Jul 18, 2023
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Jul 19, 2023
The additional osx-x64 and osx-arm64 legs added for NativeAOT in dotnet#89018 caused the `runtime.osx-*.Microsoft.DotNet.ILCompiler` and runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated. This change makes sure we only publish them from one leg (the CoreCLR one).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
The additional osx-x64 and osx-arm64 legs added for NativeAOT in #89018 caused the `runtime.osx-*.Microsoft.DotNet.ILCompiler` and runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated. This change makes sure we only publish them from one leg (the CoreCLR one).
carlossanlop
pushed a commit
that referenced
this pull request
Jul 19, 2023
The additional osx-x64 and osx-arm64 legs added for NativeAOT in #89018 caused the `runtime.osx-*.Microsoft.DotNet.ILCompiler` and runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated. This change makes sure we only publish them from one leg (the CoreCLR one). Co-authored-by: Alexander Köplinger <[email protected]>
akoeplinger
added a commit
that referenced
this pull request
Jul 19, 2023
The additional osx-x64 and osx-arm64 legs added for NativeAOT in #89018 caused the `runtime.osx-*.Microsoft.DotNet.ILCompiler` and runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated. This change makes sure we only publish them from one leg (the CoreCLR one).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for the NativeAOT work in xamarin-macios