-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use-out-of-scope in signature comparison #88928
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsPropagate token list to callers by copying instead of passing an out-of-scope address. Fixes a violation found by ASAN. Fixes the underlying issue in #87807
|
…useful empty state that won't segfault." This reverts commit 28b3fd5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Only failure is a timeout: |
Propagate token list to callers by copying instead of passing an out-of-scope address.
Fixes a violation found by ASAN.
Fixes the underlying issue in #87807
This PR is blocking #74623 (the ASAN enabling PR) from being green.