Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][tests] Enable dynamic linking for maccatalyst in sandbox environment #88847

Merged

Conversation

kotlarmilos
Copy link
Member

This PR should fix the failing maccatalyst jobs in the sandbox environment by enabling dynamic linking. Additionally, it explicitly sets MonoForceInterpreter to false in the sample app when running in the full AOT mode on iossimulator and maccatalyst.

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Jul 13, 2023
@kotlarmilos kotlarmilos self-assigned this Jul 13, 2023
@ghost
Copy link

ghost commented Jul 13, 2023

Tagging subscribers to 'os-maccatalyst': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR should fix the failing maccatalyst jobs in the sandbox environment by enabling dynamic linking. Additionally, it explicitly sets MonoForceInterpreter to false in the sample app when running in the full AOT mode on iossimulator and maccatalyst.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Codegen-AOT-mono, os-ios, os-maccatalyst

Milestone: 8.0.0

@kotlarmilos
Copy link
Member Author

/cc: @jandupej This PR should unblock you.

@kotlarmilos
Copy link
Member Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88847 in repo dotnet/runtime

@kotlarmilos
Copy link
Member Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos kotlarmilos merged commit ae068fe into dotnet:main Jul 14, 2023
138 of 161 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants