-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pooled array leak #88810
Merged
Merged
fix pooled array leak #88810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned danmoseley
Jul 13, 2023
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 13, 2023
danmoseley
commented
Jul 13, 2023
src/libraries/Common/tests/System/Net/Security/FakeNtlmServer.cs
Outdated
Show resolved
Hide resolved
danmoseley
added
area-System.IO
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 13, 2023
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsI ran the tests with some rudimentary tracing on the array pool and found one leak.
|
danmoseley
force-pushed
the
vsb.leak.copy
branch
from
July 13, 2023 13:12
5ef6517
to
7c3639d
Compare
I'll close until I've finished. |
danmoseley
force-pushed
the
vsb.leak.copy
branch
from
July 14, 2023 02:28
7c3639d
to
6d22946
Compare
OK hopefully ready for review now. |
|
stephentoub
reviewed
Jul 17, 2023
src/libraries/Common/tests/System/Net/Security/FakeNtlmServer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/IO/FileCleanupTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/Tests/System/Text/ValueStringBuilderTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/Tests/System/Text/ValueStringBuilderTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/Tests/System/Text/ValueStringBuilderTests.cs
Outdated
Show resolved
Hide resolved
Any other feedback @stephentoub |
stephentoub
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the tests with some rudimentary tracing on the array pool and found one leak.