JIT: Always consider empty remainders to be dying in physical promotion #88665
Conversation
Liveness takes a few shortcuts that means it doesn't always handle the case where there is no remainder as the remainder dying, so add a special case in StructDeaths::IsRemainderDying to take care of this case. Some minor improvements from more last-use copy omission are expected.
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsLiveness takes a few shortcuts that means it doesn't always handle the case where there is no remainder as the remainder dying, so add a special case in StructDeaths::IsRemainderDying to take care of this case. Some minor improvements from more last-use copy omission are expected. Without this the bug in #88616 is hard to expose because it requires there to be a remainder that is fully defined between the two calls.
|
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS Diffs. Some minor improvements due to more last-use copy omission. The failure is #88582. |
|
license/cla seems to be stuck... will rerun by pushing a new commit. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Liveness takes a few shortcuts that means it doesn't always handle the case where there is no remainder as the remainder dying, so add a special case in StructDeaths::IsRemainderDying to take care of this case.
Some minor improvements from more last-use copy omission are expected.
Without this the bug in #88616 is hard to expose because it requires there to be a remainder that is fully defined between the two calls.