[MONO] Incorrect timestamps for perf events #88428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-Build-mono
community-contribution
vargaz
reviewed
Jul 5, 2023
saitama951
force-pushed
the
incorrect_timestamp
branch
from
45d002c to
1f52888
Compare
saitama951
force-pushed
the
incorrect_timestamp
branch
from
53e46ec to
2a2da66
Compare
vargaz
approved these changes
Jul 6, 2023
lambdageek
approved these changes
Jul 6, 2023
Member
|
/backport to release/7.0-staging |
Contributor
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5478351548 |
Contributor
|
@lambdageek backporting to release/7.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: changing defs
Using index info to reconstruct a base tree...
M src/mono/cmake/config.h.in
M src/mono/cmake/configure.cmake
Falling back to patching base and 3-way merge...
Auto-merging src/mono/cmake/configure.cmake
Auto-merging src/mono/cmake/config.h.in
CONFLICT (content): Merge conflict in src/mono/cmake/config.h.in
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 changing defs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@lambdageek an error occurred while backporting to release/7.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when added support for the debug info records with #85107 ,The perf was not able to map to the jitted-so's on top of the BenchmarkDotNet library.
i.e
hence the perf source code annotation fails. on deeper inspection with the perf script logs, we noticed that the fork events and the mmap2 events were out of order. it seems
HAVE_CLOCK_GETTIMEi.e inconfigure.acwas removed while cleaning up the older makefile build system. hence returning always 0.reference commit:- #47758
@vargaz as mentioned in the previous PR I added the macro to the cmake
#88373