Fix which path is taken in Enumerable.Select for empty partition #88425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My recent changes to improve perf of some LINQ iterators by implementing `IList<T>` caused Select on an empty partition to start preferring a path that wasn't optimized for empty. This fixes it. I searched and don't see any other operators that would be similarly negatively affected.
|
Tagging subscribers to this area: @dotnet/area-system-linq Issue DetailsMy recent changes to improve perf of some LINQ iterators by implementing Fixes the one related benchmark from #88376 (EmptyTakeSelectToArray). None of the other benchmarks there are related to my previous change.
|
IDisposable
reviewed
Jul 5, 2023
src/libraries/System.Linq/src/System/Linq/Enumerable.SizeOpt.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 5, 2023
This was referenced Jul 13, 2023
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent changes to improve perf of some LINQ iterators by implementing
IList<T>caused Select on an empty partition to start preferring a path that wasn't optimized for empty. This fixes it. I searched and don't see any other operators that would be similarly negatively affected.Fixes the one related benchmark from #88376 (EmptyTakeSelectToArray). None of the other benchmarks there are related to my previous change.