-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISC-V][JIT] Fix DevDiv_718151 test #88404
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
Part of #84834
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PUTARG_SPLIT
path needs to be updated as well.
src/coreclr/jit/codegenriscv64.cpp
Outdated
if (source->OperGet() == GT_LCL_VAR) | ||
// If we have an HFA we can't have any GC pointers, | ||
// if not then the max size for the struct is 16 bytes | ||
if (compiler->IsHfa(layout->GetClassHandle())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no HFAs on RISCV, so this checking can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@clamp03 Can you update |
Oh. I missed the comment. Sorry. I will update then request reviews. Thank you. |
- Update PUTARG_SPLIT - Remove converting in PUTARG_STK
@jakobbotsch @SingleAccretion Could you please review? Thank you. |
Please review. Thank you in advance. |
/azp run runtime-coreclr superpmi-replay, runtime-coreclr superpmi-diffs |
Azure Pipelines successfully started running 2 pipeline(s). |
ClassLayout* layout = source->AsBlk()->GetLayout(); | ||
// Pick a register to store intermediate values in for the to-stack | ||
// copy. It must not conflict with addrReg. We try to prefer an | ||
// argument register since those can always use thumb encoding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"thumb encoding" is an ARM32 thing, but let's not rerun CI for a simple comment change. Feel free to include it in a future change. (Here and below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I will update later.
PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD)
on ARM/64 #70861)./JIT/Regression/JitBlue/DevDiv_718151/DevDiv_718151/DevDiv_718151.sh
testPart of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov