Improve LoggerFactory and Logger debugging #88313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsLoggerFactoryBefore
After
LoggerBefore
After
|
JamesNK
changed the title
tarekgh
reviewed
Jul 3, 2023
tarekgh
reviewed
Jul 3, 2023
tarekgh
reviewed
Jul 3, 2023
| @@ -19,7 +19,7 @@ public MessageLogger(ILogger logger, string? category, string? providerTypeFullN | |||
|
|
|||
| public ILogger Logger { get; } | |||
|
|
|||
| public string? Category { get; } | |||
There was a problem hiding this comment.
Nullable analysis says it can't. I changed it because I didn't see any code paths that allowed null.
JamesNK
commented
Jul 3, 2023
tarekgh
approved these changes
Jul 3, 2023
This was referenced Jul 4, 2023
11 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggerFactory
The changes to
LoggerFactorymake it easy to discover the common configuration for logging:Before
After
Logger
Loggerchanges denormalize information back to an understandable form. It's now easy to see what providers are enabled for this logger and the min log level for each provider.Before
After