Implement JsonTypeInfoResolver.WithAddedModifier #88255
Conversation
dotnet-issue-labeler
bot
added
area-System.Text.Json
new-api-needs-documentation
labels
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #86440.
|
| internal sealed class JsonTypeInfoResolverWithAddedModifiers : IJsonTypeInfoResolver | ||
| { | ||
| private readonly IJsonTypeInfoResolver _source; | ||
| private readonly Action<JsonTypeInfo>[] _modifiers; |
There was a problem hiding this comment.
I'm curious if you could support it by List and count (you always append so technically you could reuse same instance) or ImmutableArray/List - not a big deal - this is not in a hot path
There was a problem hiding this comment.
We want the resolver instances to be immutable -- if we reused the same List<T> then calling var bar = foo.WithAddedModifiers(...); then foo would be mutated.
...t.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoResolverWithAddedModifiers.cs
Show resolved
Hide resolved
...t.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoResolverWithAddedModifiers.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Fix #86440.