Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryFindSystemTimeZoneById #88071

Merged
merged 5 commits into from
Jun 29, 2023
Merged

TryFindSystemTimeZoneById #88071

merged 5 commits into from
Jun 29, 2023

Conversation

AlexRadch
Copy link
Contributor

Close #66928 issue.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 26, 2023
@ghost
Copy link

ghost commented Jun 26, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Close #66928 issue.

Author: AlexRadch
Assignees: -
Labels:

new-api-needs-documentation, area-System.DateTime
Milestone: -

@tarekgh tarekgh added this to the 8.0.0 milestone Jun 26, 2023
@build-analysis build-analysis bot mentioned this pull request Jun 27, 2023
Closed
@AlexRadch
converting if-else to switch statement
2899919 
moving the common code to timezoneinfo.cs
@build-analysis build-analysis bot mentioned this pull request Jun 28, 2023
Closed
@tarekgh
Copy link
Member

tarekgh commented Jun 28, 2023 

    private const int MaxKeyLength = 255;

move it to TimeZoneInfo.cs

Refers to: src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Win32.cs:35 in 2899919. [](commit_id = 2899919, deletion_comment = False)

@tarekgh
Copy link
Member

tarekgh commented Jun 29, 2023

Thanks @AlexRadch for providing these changes.

@tarekgh tarekgh merged commit bef8818 into dotnet:main Jun 29, 2023
@AlexRadch AlexRadch deleted the TryFindSystemTimeZoneById branch June 29, 2023 17:22
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-System.DateTime community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: TryFindSystemTimeZoneById
3 participants
@AlexRadch @tarekgh @danmoseley