Add span-based static Create overloads for immutable collections #87945
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsContributes to #87569
|
| /// <typeparam name="T">The type of items stored by the collection.</typeparam> | ||
| /// <param name="items">The items to prepopulate.</param> | ||
| /// <returns>The new immutable collection.</returns> | ||
| public static ImmutableHashSet<T> Create<T>(ReadOnlySpan<T> items) | ||
| { | ||
| return ImmutableHashSet<T>.Empty.Union(items); |
There was a problem hiding this comment.
I know this predates your changes, but it strikes me as odd that we're defining a core factory method in terms of a "Union" operation. Not familiar with the Union implementation but it sounds like it might be introducing unnecessary checks on the LHS?
There was a problem hiding this comment.
Potentially. Happy for us to address any overheads here separately.
It's possible, but we want these anyway for devs to use directly :) We'd like them on the other collections like List and HashSet as well, but we can't add the overloads there we want them yet because they result in ambiguity errors for some callers; that problem doesn't exist for the immutable collections given their current shape. |
Contributes to #87569