Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster optimized frozen dictionary creation (1/n) #87510

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Faster optimized frozen dictionary creation (1/n) #87510

merged 3 commits into from
Jun 14, 2023

Commits on Jun 13, 2023

  1. every strategy needs an array of keys, we can create it up-front and … 

    …iterate over it rather than the dictionary to get min and max lengths (1-2% gain)
    @adamsitnik
    adamsitnik committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    095762a View commit details
    Browse the repository at this point in the history

  2. Instead of ensuring that at least 95% of data is good, we stop when w… 

    …e know that at least 5% is bad (13-14% gain)
    @adamsitnik
    adamsitnik committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    98a7a02 View commit details
    Browse the repository at this point in the history

  3. toggle the direction and re-use the comparer and hashset (3% time gai… 

    …n, 12% allocations reduction)
    @adamsitnik
    adamsitnik committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    0b631d9 View commit details
    Browse the repository at this point in the history