-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DeserializeAsyncEnumerable generic recursion issue. #87276
Fix DeserializeAsyncEnumerable generic recursion issue. #87276
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsRefactors the System.Text.Json.SourceGeneration.Tests AOT sizemainTotal accounted size: 106.5 MB PR branchTotal accounted size: 60.6 MB Contributes to #87078.
|
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue DetailsRefactors the System.Text.Json.SourceGeneration.Tests AOT sizemainTotal accounted size: 106.5 MB PR branchTotal accounted size: 60.6 MB Contributes to #87078.
|
Updated size diffs for the Microsoft Store (including this and #87211):
Delta: -4.07 MB (-5.88%) Compared with the previous diffs (#84015 (comment)), which had a delta of -1.698 KB (-2.55%) from 7.0.2, the updated results are incredibly impressive, this is amazing!! Well over twice as much package size size reduction than Preview 5!!! 🎉🎉🎉 Really amazing work @eiriktsarpalis and the whole team! 😄 |
Refactors the
DeserializeAsyncEnumerable
moving the logic away fromJsonTypeInfo<T>
and into a static method inJsonSerializer
. This should fully address the generic recursion issues we've been seeing creep up in AOT.System.Text.Json.SourceGeneration.Tests AOT size
main
Total accounted size: 106.5 MB
PR branch
Total accounted size: 60.6 MB
Contributes to #87078.