-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine two table lookups into one while formatting Guid on Arm64 #87126
Combine two table lookups into one while formatting Guid on Arm64 #87126
Conversation
Micro-benchmarking on an N1 system shows the following improvements.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although, I'd prefer us doing this in JIT (to merge two subsequent table lookups)
/azp run runtime-coreclr libraries-jitstressregs, runtime-coreclr libraries-jitstress-random, runtime-coreclr libraries-jitstress, runtime-coreclr libraries-jitstress2-jitstressregs |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run runtime-coreclr libraries-jitstressregs, runtime-coreclr libraries-jitstress-random, runtime-coreclr libraries-jitstress, runtime-coreclr libraries-jitstress2-jitstressregs |
Azure Pipelines successfully started running 4 pipeline(s). |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsContributes towards the issue #84328
|
Seems like the test failures are because of the cancellations. Not sure why the tests got cancelled. |
/azp run runtime-coreclr libraries-jitstressregs, runtime-coreclr libraries-jitstress-random, runtime-coreclr libraries-jitstress, runtime-coreclr libraries-jitstress2-jitstressregs |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run runtime-coreclr libraries-jitstressregs, runtime-coreclr libraries-jitstress-random, runtime-coreclr libraries-jitstress, runtime-coreclr libraries-jitstress2-jitstressregs |
Azure Pipelines successfully started running 4 pipeline(s). |
One of the failing issue is #83316, but there are some arm64 failures in https://dev.azure.com/dnceng-public/public/_build/results?buildId=298474&view=ms.vss-test-web.build-test-results-tab&runId=6039742&resultId=199446&paneView=debug that you might want to check. |
Hi @kunalspathak, I couldn't run the windows on Arm64 failure as I don't have access to such machine. Instead, I tried to reproduce the failure on ubuntu 18.04 as it looked like the similar While running the failures from the pipeline, we get a script to reproduce failure that basically runs the following command after setting the required environment variables.
This runs all the |
I just looked around and noticed that similar tests failed few weeks back and there is #86563 for that. So I think we should be good here. Since they repro with random seeds, the failures is not consistent week over week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Hi @kunalspathak @EgorBo, is there anything that I can do to push this patch forward? 🙂 |
Contributes towards the issue #84328