[mono] Use underlying type in RuntimeHelpers.GetSpanDataFrom #87019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it work correctly for spans of enums Fixes dotnet#86865 Note that in net8 RuntimeHelpers.CreateSpan<T> is an intrinsic, so GetSpanDataFrom is never called directly. But in net7 CreateSpan is not intrinsified on Mono, so the underlying method really does get called.
dotnet-issue-labeler
bot
added
the
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsMake it work correctly for spans of enums Fixes #86865 Note that in net8 RuntimeHelpers.CreateSpan is an intrinsic, so GetSpanDataFrom is never called directly. But in net7 CreateSpan is not intrinsified on Mono, so the underlying method really does get called.
|
lambdageek
removed
the
needs-area-label
|
This isn't super-critical for net8, but the intention is to backport this to net7 |
stephentoub
reviewed
Jun 1, 2023
stephentoub
approved these changes
Jun 1, 2023
|
/backport to release/7.0-staging |
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5147526682 |
This was referenced Jun 1, 2023
vargaz
approved these changes
Jun 1, 2023
This was referenced Jun 2, 2023
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it work correctly for spans of enums
Fixes #86865
Note that in net8 RuntimeHelpers.CreateSpan is an intrinsic, so GetSpanDataFrom is never called directly.
But in net7 CreateSpan is not intrinsified on Mono, so the underlying method really does get called.