-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use the cbl-mariner webassembly images. #86806
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThis is one of the last official build targets that we weren't already using CBL-Mariner to build with.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis is one of the last official build targets that we weren't already using CBL-Mariner to build with.
|
These images are 100% borked right now, yes? I just tried to use them for ICU, and am getting Docker errors |
Guess I missed some of the AzDO requirements for the containers... |
/azp run runtime, dotnet-linker-tests, runtime-wasm |
Azure Pipelines successfully started running 3 pipeline(s). |
The WASM legs build the apps on the build system, so the |
|
Those numbers don't line up, glibc 2.34 is not what Mariner-built stuff should be offering. Our Mariner build images have the Mariner base OS, and are SUPPOSED TO cross-compile against a target OS (Ubuntu 16.04 in most cases) in |
It's the Mariner base image itself. The WASM build legs build the "cross" tools on the base image. We don't ship those components; we build them again in another leg to produce the "cross" tools built against the correct target rootfs. We only hit this problem because WASM uses mono-aot-cross to build tests on Helix machines. This was working beforehand because the image where we built wasm was the same or older base image as the image we run wasm tests on. The solution (which I need to look into) is to build the cross tools like mono-aot-cross against the correct rootfs. |
Does this change need to be backported? |
We're still determining the plans for these infra changes for existing release branches. |
…names as they represent the host OS/Arch for the AOT compiler.
…parate item group
/azp run runtime, dotnet-linker-tests, runtime-wasm |
Azure Pipelines successfully started running 3 pipeline(s). |
…ture for the WASM linker tests leg.
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Failures are either known or #86533 |
The official build started failing after this https://dev.azure.com/dnceng/internal/_build/results?buildId=2197698&view=logs&j=f5dc5c25-a228-5330-5793-27e0590c86b7&t=0577d8ca-da8f-5816-9616-b0711151fa80&l=1508 |
I'm testing out a possible fix. Should have something by EOD today hopefully. |
This is one of the last official build targets that we weren't already using CBL-Mariner to build with.