You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initiated by #85965 (comment).
In the original globalization comparison tests we used to have test cases with multiple comparison options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.
Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.
Issue Details
Initiated by #85965 (comment).
In the original globalization comparison tests we used to have comparison test cases with multiple options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.
Author:
ilonatommy
Assignees:
ilonatommy
Labels:
area-System.Globalization
Milestone:
-
ilonatommy
changed the title
Cleanup.
[lib][tests] Globalization comparison tests cleanup
May 16, 2023
Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.
Issue Details
Initiated by #85965 (comment).
In the original globalization comparison tests we used to have test cases with multiple comparison options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.
@ilonatommy there is also supportedCmpOptions which looks like same property. As in my current PR #85965 I am touching a lot of lines after this PR got merged there will be need to check a lot of lines one by one. So my suggestion is either I can do these refactoring in my current PR, either let's do this after my PR got merged?
This will get in with #85965. We checked that CI is passing with the changes but decided that it's less confusing for Meri to incorporate the changes directly in her PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ilonatommy
changed the title
ghost
locked as resolved and limited conversation to collaborators
Initiated by #85965 (comment).
In the original globalization comparison tests we used to have test cases with multiple comparison options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.