Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental generator for illink analyzer tests #86260

Merged
merged 1 commit into from
May 15, 2023

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented May 15, 2023

Changes the existing generator for ILLink.RoslynAnalyzer testcases to be an IIncrementalGenerator, per #86190. Fixes #86190.

@sbomer sbomer requested a review from marek-safar as a code owner May 15, 2023 17:47
@sbomer sbomer requested a review from jkoritzinsky May 15, 2023 17:47
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 15, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label May 15, 2023
@ghost ghost assigned sbomer May 15, 2023
@sbomer sbomer requested a review from agocke May 15, 2023 17:47
@ghost
Copy link

ghost commented May 15, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Changes the existing generator for ILLink.RoslynAnalyzer testcases to be an IIncrementalGenerator, per #86190. Fixes #86190.

Author: sbomer
Assignees: -
Labels:

linkable-framework, needs-area-label

Milestone: -

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbomer sbomer merged commit 1e8db55 into dotnet:main May 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2023
@sbomer sbomer deleted the illinkAnalyzerIncrementalGenerator branch November 3, 2023 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ILLink.RoslynAnalyzer.Tests.Generator to be an IIncrementalGenerator-based source generator
2 participants