-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from 7 repositories #85913
[main] Update dependencies from 7 repositories #85913
Conversation
…0507.3 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.5.23251.1 -> To Version 8.0.0-preview.5.23257.3
… 20230508.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23228.1 -> To Version 14.0.0-alpha.1.23258.2
…30509.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23253.1 -> To Version 8.0.0-prerelease.23259.1
…08.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.5.23252.1 -> To Version 8.0.0-preview.5.23258.1
…ild 20230508.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23258.1
…09.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23252.1 -> To Version 0.11.4-alpha.23259.1
…ild 20230509.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23259.2
…ild 20230515.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23265.2
…15.2 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23252.1 -> To Version 0.11.4-alpha.23265.2
The installer tests fail with this error now:
|
Ah we hit a similar issue on the sdk dependency update: dotnet/sdk#32250 (comment) I'm not sure why we hit this here though, it looks like the installer tests don't run with the just built dotnet runtime? |
@elinor-fung for ideas. It's possible that we run the test with the SDK (as the tests themselves are not running the tested bits in-proc anyway), but I would expect that to be internally consistent. |
The installer tests themselves run with the SDK, not the live-built runtime. The tests launch separate processes - those processes are the live-built hosts using the live-built runtime. |
runtime/src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj Line 24 in 4db4bb5
This PR updates that version to one that uses System.Buffers.SearchValues .
I'm not sure what to do here. The basic situation is an app pulling in a newer
|
We could change the package reference to point to the "old" version of S.T.Json, then it should work with the SDK in the repo. And then when we update the SDK - this will break again and we will revert it back to the live-built S.T.Json. |
I'm seeing if we can have get that dependency stop propagating to the tests / test utils - hoping to avoid the pin version / break / revert (and any second-level effect of that from SDK consuming Microsoft.NET.HostModel). If not, we can go with pointing at an old version to unblock this flow. cc @MihaZupan for the OOB package behaviour per #85913 (comment). Not sure if that is a scenario we think users will hit, but I didn't see anything in the breaking change issue that mentions it or indicates how to resolve it. |
This is all within .NET 8, taking advantage of new APIs added in .NET 8 from an asset targeting .NET 8. We don't create breaking change issues for such things. It's a key tenet of adding new APIs that we use them wherever it's relevant to do so. And there's an expectation that if someone is trying out .NET 8, they're doing so using consistent preview versions of the libraries and runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures appear to be unrelated, thank you @elinor-fung
…30509.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23253.1 -> To Version 8.0.0-prerelease.23259.1
… 20230519.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23228.1 -> To Version 14.0.0-alpha.1.23269.1
The iOS failure is unrelated, merging. |
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
From https://github.com/dotnet/llvm-project
From https://github.com/dotnet/xharness
From https://github.com/dotnet/emsdk
From https://github.com/dotnet/hotreload-utils
From https://github.com/dotnet/cecil
From https://github.com/dotnet/runtime-assets