-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid reporting frozen segments in GetGenerationBounds #85727
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsAvoid reporting the frozen segments through Reporting a slightly reduced value for Open questions:
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andrew!
Thats fine by me.
We should not emit non-gc segments from a GCGenerationRange event, it doesn't match the abstraction we are trying to present to users. |
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
3ea1e70
to
bdac35d
Compare
My question is about the following statement:
I may wrong, but I see the issue with old profilers which does not known about |
Yes.
Yes.
Yes. And this is part of the intentional breaking change related to NonGC heap diagnostics, see dotnet/diagnostics#4156 for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Noah Falk <[email protected]>
Co-authored-by: Noah Falk <[email protected]>
Co-authored-by: Noah Falk <[email protected]>
db4755f
to
08d1a42
Compare
Fixes #87834
Avoid reporting the frozen segments through
GetGenerationBounds
, this would be a duplicate withGetNonGCHeapBounds
.Reporting a slightly reduced value for
reservedLength
inGetNonGCHeapBounds
to be consistent withGetGenerationBounds
Avoid reporting the
GCGenerationBounds
event for frozen segments.Rename the
GCHeapCollect
keyword toManagedHeapCollect
.Would love to merge this PR if there is no issue with the current code - customers are starting to notice the bug - if we found anything additional that will increase the scope of this PR we can address them later before .net 8.