Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix stress builds #85342

Merged

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Apr 25, 2023

Fix #85338, by switching to centos-stream8 as recommended in #85342 (comment).

This also addresses the concerns from https://github.com/dotnet/runtime/pull/84793/files#r1174173867.

@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

An attempt to fix #85338, based on #84795 and also try to switch the distro as discussed in https://github.com/dotnet/runtime/pull/84793/files#r1174173867.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@azure-pipelines

This comment was marked as resolved.

2 similar comments
@azure-pipelines

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@antonfirsov antonfirsov marked this pull request as draft April 25, 2023 18:29
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

This comment was marked as resolved.

eng/docker/libraries-sdk.linux.Dockerfile Outdated Show resolved Hide resolved
eng/docker/libraries-sdk.linux.Dockerfile Outdated Show resolved Hide resolved
@rzikm
Copy link
Member

rzikm commented Apr 26, 2023

As sbomer commented, the issue is missing lld linker, either we need to update the docker image to include lld or switch to one which has it. The OpenSSL config changes are not necessary here. They were needed in the other PR because Ubuntu 22.04 has OpenSSL 3 which disabled some legacy functionality required by libgssl (needed for Kerberos stuff)

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-ssl

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

@sbomer @rzikm thanks for the clarification! I missed the fact the OpenSSL hack has nothing to do with the core issue (lack of lld).

Switching to centos-stream8 fixed these pipelines, so this is ready for review now.

@antonfirsov antonfirsov merged commit 678b4c8 into dotnet:main Apr 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
@karelz karelz added this to the 8.0.0 milestone May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpStress] [SslStress] Linux stress test builds are broken
6 participants