-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nativeaot][tests] Add Native AOT iOS perf scenarios #85317
[nativeaot][tests] Add Native AOT iOS perf scenarios #85317
Conversation
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger Issue DetailsThis PR updates the CI jobs to include the Native AOT iOS performance scenarios. The changes include building the NativeAOT iOS scenarios and running them, as well as updating the underlying scripts and project files to support it. Additionally, it separates the scenarios from the current Mono AOT sample measurements. Additionally, it temporarily fixes regression to allow testing. The regression will be fixed on the main in a separate PR tracked in #80911.
|
This PR is ready for review. The performance results can be found in the Native AOT performance measurements:
Mono performance measurements:
@LoopedBard3 I will keep you posted. |
@@ -29,8 +29,8 @@ | |||
<DevTeamProvisioning Condition="'$(DevTeamProvisioning)' == ''">adhoc</DevTeamProvisioning> | |||
<EnableAppSandbox Condition="'$(EnableAppSandbox)' == ''">false</EnableAppSandbox> | |||
</PropertyGroup> | |||
|
|||
<Import Project="$(CoreClrProjectRoot)nativeaot\BuildIntegration\Microsoft.NETCore.Native.targets" /> | |||
<!-- Fix temporary regression, will be fixed on the main in a separate PR: https://github.com/dotnet/runtime/issues/80911 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comment: https://github.com/dotnet/runtime/pull/85317/files#r1210389112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just a small note on "symbol-stripped" scenarios, that in those cases we are stripping local symbols only via strip -x
Thanks! If we maintain consistency across all platforms and strip in the same way, it should be fine. If I recall correctly, we encountered an issue with global symbols stripping. |
This PR updates the CI jobs to include the Native AOT iOS performance scenarios. The changes include building the NativeAOT iOS scenarios and running them, as well as updating the underlying scripts and project files to support it. Additionally, it separates the scenarios from the current Mono AOT sample measurements.
Additionally, it temporarily fixes regression to allow testing. The regression will be fixed on the main in a separate PR tracked in #80911.
Preliminary perf measurements for the HelloiOS app using Native AOT.
SOD - iOS HelloWorld Native AOT Zip Size
SOD - iOS HelloWorld Native AOT .app
Device Startup - iOS HelloWorld Native AOT