Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Expanding timeouts for long running test projects #85313

Merged
merged 6 commits into from
Apr 28, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 25, 2023

Expanding timeouts and adding more logging to see which tests are hanging the whole suite.
Fixes #85304

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Apr 25, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Apr 25, 2023
@pavelsavara pavelsavara self-assigned this Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Exploring timeouts #85304

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-Build-mono

Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review April 27, 2023 18:00
@pavelsavara pavelsavara changed the title [browser] Exploring timeouts [browser] Expanding timeouts for long running test projects Apr 27, 2023
Comment on lines +234 to +237
<Timeout Condition="'%(FileName)' == 'System.Text.Json.Tests'">01:20:00</Timeout>
<Timeout Condition="'%(FileName)' == 'System.Collections.Immutable.Tests'">01:20:00</Timeout>
<Timeout Condition="'%(FileName)' == 'System.Net.WebSockets.Client.Tests'">01:20:00</Timeout>
<Timeout Condition="'%(FileName)' == 'System.Net.Http.Functional.Tests'">01:20:00</Timeout>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? A lot of work was done here to separate the project specific from these helix targets. And more is coming.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These specific projects needs extended timeout, at least at the moment. Do we have other options? Or should we extend the timeout to all jobs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm keep this here for now. I will move the whole thing out for library tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that here we don't have individual projects loaded in MSBuild, we only have zip files in folders.

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

src/libraries/sendtohelix-wasm.targets Show resolved Hide resolved
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
@pavelsavara pavelsavara deleted the wasm_timeouts branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various WASM timeouts on CI
3 participants