[browser] Expanding timeouts for long running test projects #85313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
wasm_timeouts
branch
from
a70ac9f
to
91806a4
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 26, 2023
pavelsavara
changed the title
radical
reviewed
Apr 27, 2023
Comment on lines
+234
to
+237
| <Timeout Condition="'%(FileName)' == 'System.Text.Json.Tests'">01:20:00</Timeout> | ||
| <Timeout Condition="'%(FileName)' == 'System.Collections.Immutable.Tests'">01:20:00</Timeout> | ||
| <Timeout Condition="'%(FileName)' == 'System.Net.WebSockets.Client.Tests'">01:20:00</Timeout> | ||
| <Timeout Condition="'%(FileName)' == 'System.Net.Http.Functional.Tests'">01:20:00</Timeout> |
There was a problem hiding this comment.
Why is this needed? A lot of work was done here to separate the project specific from these helix targets. And more is coming.
There was a problem hiding this comment.
These specific projects needs extended timeout, at least at the moment. Do we have other options? Or should we extend the timeout to all jobs?
There was a problem hiding this comment.
hmm keep this here for now. I will move the whole thing out for library tests.
There was a problem hiding this comment.
The problem is that here we don't have individual projects loaded in MSBuild, we only have zip files in folders.
This was referenced Apr 27, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding timeouts and adding more logging to see which tests are hanging the whole suite.
Fixes #85304