Directory.Build.props: restore previous behavior when targetting 'other' TargetOSes from Windows. #85246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' TargetOSes from Windows.
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details@ViktorHofer this is a suggestion for #82832 (comment). ptal.
|
tmds
commented
Apr 24, 2023
|
|
||
| <!-- On Windows, we can build for Windows and Mobile. | ||
| For other TargetOSes, create a "win" build, built from TargetOS sources and "win" pre-built packages. --> | ||
| <_portableOS Condition="'$(HostOS)' == 'win' and '$(TargetsMobile)' != 'true'">win</_portableOS> |
There was a problem hiding this comment.
By setting _portableOS, we're controlling both OutputRID which names the output win, and PackageOS which controls what packages are consumed for the target.
ViktorHofer
approved these changes
Apr 24, 2023
This was referenced Apr 24, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ViktorHofer this is a suggestion for #82832 (comment). ptal.