-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISC-V] Fix build error #85232
[RISC-V] Fix build error #85232
Conversation
clamp03
commented
Apr 24, 2023
- Fixed build error due to no return value in non-void function (ins_Move_Extend)
- CoreCLR RISC-V architecture port #84834
- Fixed build error due to no return value in non-void function (ins_Move_Extend) - dotnet#84834
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
@shushanhf Thank you. When I saw this build error, before fixing this error, I searched and found your patch which fix only LA64. So I pushed this for RISC64. If it conflicts, then I would fix conflicts. Actually, someone's patches can be conflict with mine. I don't care and just fix it. I cannot prevent all PRs from others. Do you have any plan to add CI for LA64? I think LA64 build and tests frequently fails. (RISC-V too. 😢 ) It already occurs 8 times #85216, #85151, #85140, #84971, #84970, #84970, #84960 and #83370 for only March and April. Unfortunately, we did 2 times. I am very sorry about that. However, we cannot prevent all mistakes even if we really carefully check. I think CI is very good option to keep LA64 safely. If you don't mind, I can help. Could you please let me know how to build LA64? |
We have constructed a local CI for LA64. Thanks |
@shushanhf One more notification, I fixed an error in RISC-V. bed8b9c. When optimizing branch is applied, the patch reverses condition in GT_JCMP. In my opinion, it is related to LA64 too. If you think it needs for LA64 ASAP, you can copy codes for LA64 and make another PR. I will resolve a conflict in my side. I think it takes long time to merge my PR. :) + From next time, if you don't mind, I hope requesting you to add RISCV if your patch is useful for both LA64 and RISCV. And I will add you as a CC if my PR is good for both LA64 and RISCV. I think we have many things we can share and help. |
We had already fixed this for LA64. |