[browser] JSObject thread affinity assertions #84981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pavelsavara
commented
Apr 18, 2023
pavelsavara
commented
- add asserts for JSObject and JSException that they could be used only on original thread where they are bound to JS.
- add asserts that legacy interop only works on main thread - ID 1
pavelsavara
added
arch-wasm
Member
Author
|
/azp run runtime-wasm |
pavelsavara
force-pushed
the
browser_jsobject_thread_owner
branch
from
5c67568 to
fd383b6
Compare
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
changed the title
This was referenced Apr 18, 2023
Member
Author
|
CI failures are unrelated |
lambdageek
approved these changes
Apr 18, 2023
ilonatommy
reviewed
Apr 19, 2023
...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Show resolved
Hide resolved
ilonatommy
approved these changes
Apr 19, 2023
Member
ilonatommy
left a comment
ilonatommy
left a comment
There was a problem hiding this comment.
Looks good, only small copy-paste errors.
....JavaScript/src/System/Runtime/InteropServices/JavaScript/Legacy/LegacyHostImplementation.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilona Tomkowicz <[email protected]>
Co-authored-by: Ilona Tomkowicz <[email protected]>
…stem/Runtime/InteropServices/JavaScript/Legacy/LegacyHostImplementation.cs Co-authored-by: Ilona Tomkowicz <[email protected]>
Co-authored-by: Ilona Tomkowicz <[email protected]>
# Conflicts: # src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.