Use Roslyn Source Generator Testing SDK to test interop source generators #84867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Diagnostic tests that target the live reference pack to use the test harness.
…terloop diagnostics tests to use the harness.
…se the actual generator with the testing SDK as it now supports testing source generators with code fixers in a single test.
…sed on a given test's requested tfm.
…ng to use the source generator test suite.
jkoritzinsky
added
area-System.Runtime.InteropServices
test-enhancement
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThis lets us more directly test the UX for the diagnostics we emit from the interop source generators. Opening in draft form now as I've only moved over the LibraryImportGenerator tests (and I need to move over the ComInterfaceGenerator tests as well due to some changes in common files for defining code snippets) Contributes to #84441
|
…forwarder fallback. This fixes the last compile error we have for invalid managed->unmanaged stubs.
…leFails test suite.
This was referenced Apr 18, 2023
jkoritzinsky
requested review from
AaronRobinsonMSFT and
elinor-fung
and removed request for
AaronRobinsonMSFT
AaronRobinsonMSFT
approved these changes
May 8, 2023
|
I converted one test at a time and validated that we didn't lose any tests in the conversion. Failures are unrelated, so I'll merge this in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us more directly test the UX for the diagnostics we emit from the interop source generators.
Opening in draft form now as I've only moved over the LibraryImportGenerator tests (and I need to move over the ComInterfaceGenerator tests as well due to some changes in common files for defining code snippets)
Contributes to #84441