Publish Aggregated Values For Counter and UpDownCounter For System.Diagnostics.Metrics
#84846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… just deltas). Also added tests.
ghost
added
area-System.Diagnostics.Metric
community-contribution
This was referenced Apr 14, 2023
noahfalk
reviewed
Apr 15, 2023
There was a problem hiding this comment.
Thanks @kkeirstead! I think this is on the right track, but there is some fishy behavior in the tests I can't yet explain. Comments inline.
...braries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RateAggregator.cs
Outdated
Show resolved
Hide resolved
...braries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RateAggregator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs
Outdated
Show resolved
Hide resolved
noahfalk
reviewed
Apr 15, 2023
...braries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RateAggregator.cs
Outdated
Show resolved
Hide resolved
…ts and some naming
noahfalk
reviewed
Apr 18, 2023
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
noahfalk
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Thanks @kkeirstead, this looks good to me 👍 (one more suggestion above)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends the changes made in #81041 so that deltas and sums are both published for counters/updowncounters. Includes updated testing.
@noahfalk let me know if this is what you had in mind / you have any adjustments you'd like to see - once this is in I'll revisit integrating this into dotnet-monitor and dotnet-counters.