[browser][non-icu] HybridGlobalization support interning
#84695
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSuggested in comment. For performance reasons it pays off to exchange char*+lenght to string when passing data from managed code to JS.
|
| { | ||
| cmpResult = Interop.JsGlobalization.CompareString(out exceptionMessage, cultureName, pString1, string1.Length, pString2, string2.Length, options); | ||
| } | ||
| int cmpResult = Interop.JsGlobalization.CompareString(out exceptionMessage, cultureName, span1.ToString(), span2.ToString(), options); |
There was a problem hiding this comment.
Isn't this going to allocate temporary C# strings in order to pass them to JS? This will break interning too.
There was a problem hiding this comment.
I am not sure how to do it differently, if we want to operate on strings we need to at least allocate a local string in the function. We cannot change the fact that arguments enter in a form of ReadOnlySpan<char> and it looks like span, passing the C#/JS border is treated the same way as char*.
There was a problem hiding this comment.
I guess we have speed vs (icu data) size tradeoff here. If they choose hybrid, they would get size, but not speed.
Seems OK to me if the perf is around %200.
There was a problem hiding this comment.
In the past mesurements on normalization function it was more than that, around 500%. It is a good idea to start measuring how HG does in comparison to ICU4C.
There was a problem hiding this comment.
I am not sure how to do it differently, if we want to operate on strings we need to at least allocate a local string in the function. We cannot change the fact that arguments enter in a form of
ReadOnlySpan<char>and it looks like span, passing the C#/JS border is treated the same way as char*.
In that case for this the way you did it previously (passing pointers) is the only reasonable way, making a temp C#/MonoString is not going to help.
|
Closing after investigating all possible solutions. See - discussion above |
ghost
locked as resolved and limited conversation to collaborators
Suggested in comment. For performance reasons it pays off to exchange char*+lenght to string when passing data from managed code to JS.
HybridGlobalizationchange case #84019 we are passing only culture-sensitiveabc....xyzstring and that does not contain repetitive literals, we do not need to change the original implementation there.HybridGlobalizationcompare #84249, the mechanism described by @kg can be beneficial. We are changing the implementation forComparison.