Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f5b9cd4
[7.0] Update backport template and servicing docs (#84005)
carlossanlop Mar 28, 2023
57d635b
Create action to check servicing label (#84041)
github-actions[bot] Mar 28, 2023
7786569
Fix piping in yml (#84042)
hoyosjs Mar 28, 2023
4c367c7
Update check-service-labels.yml (#84044)
hoyosjs Mar 28, 2023
8c9da40
[7.0] Avoid using spanish helix queues (#83747)
carlossanlop Mar 28, 2023
80d48e9
[release/7.0] Bump to new OSX 13 AppleTV queue (#83729)
steveisok Mar 29, 2023
74d0f47
[release/7.0] disable NTLM tests on RedHat.7 (#83602)
github-actions[bot] Mar 29, 2023
fb993f5
[release/7.0] Improve servicing docs for Microsoft.Windows.Compatibil…
carlossanlop Mar 29, 2023
1cee763
Fix Iran time zone test case (#84056)
carlossanlop Mar 29, 2023
721e656
Update check-service-labels to trigger on branch edit (#84106)
hoyosjs Mar 30, 2023
05038f9
[release/7.0][mono] Use unsigned char when computing UTF8 string hash…
lambdageek Mar 30, 2023
88b65f9
Ensure that default media type is used when 'null' is passed-in to St…
github-actions[bot] Mar 30, 2023
641393e
[release/7.0] [wasm] ManagedToNativeGenerator: Skip unmanaged dlls (#…
github-actions[bot] Mar 31, 2023
fa133ae
[release/7.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#675…
simonrozsival Mar 31, 2023
7cd68bc
[release/7.0] JIT: fix bug in cloning conditions for jagged array (#8…
AndyAyersMS Mar 31, 2023
001172f
[release/7.0] Ensure free buffer space when reading TLS messages (#83…
github-actions[bot] Apr 3, 2023
5301032
[release/7.0] SyntaxValueProvider: avoid performance issue with synta…
github-actions[bot] Apr 4, 2023
f8777ff
Fixing a bug that causes us to mistakenly demote a gen2 region to gen…
github-actions[bot] Apr 4, 2023
ed90f14
Fix special sweep issue for workstation (#83342)
github-actions[bot] Apr 4, 2023
eacc9be
[release/7.0] Fix encoding problem when publishing (#83577)
ilonatommy Apr 5, 2023
4a5620b
[release/7.0] [MONO][MARSHAL] Initialize ilgen with a flag (#83813)
github-actions[bot] Apr 5, 2023
0506145
[release/7.0-staging] Update dependencies from dotnet/linker dotnet/m…
dotnet-maestro[bot] Apr 6, 2023
c2d6594
[release/7.0] Fix pinned assembly version 7.0 (#84355)
ericstj Apr 6, 2023
694c2a0
Merge branch 'release/7.0-staging' into release70
carlossanlop Apr 7, 2023
cb70e92
Manually resolve spacing conflict in check-service-labels.yml
carlossanlop Apr 7, 2023
d71dd07
Merge branch 'release70' of github.com:carlossanlop/runtime into rele…
carlossanlop Apr 7, 2023
48abc27
Merge pull request #84459 from carlossanlop/release70
carlossanlop Apr 7, 2023
7e8c33e
Reverting: Set AssemblyName.ProcessorArchitecture for compatibility. …
VSadov Apr 7, 2023
50722b0
[release/7.0] Fix reserving executable memory as per allocation type …
github-actions[bot] Apr 10, 2023
8a0b03e
[release/7.0][Android] Free up more disk space on CI builds (#84567)
steveisok Apr 10, 2023
3947f8d
Update dependencies from https://github.com/dotnet/linker build 20230…
dotnet-maestro[bot] Apr 10, 2023
d566ecf
[7.0] Reset OOB packages from 7.0.5 (#84341)
carlossanlop Apr 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/backport.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,9 @@ jobs:

## Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md) and gotten it explicitly reviewed.
**IMPORTANT**: If this backport is for a servicing release, please verify that:

- The PR target branch is `release/X.0-staging`, not `release/X.0`.

- If the change touches code that ships in a NuGet package, you have added the necessary [package authoring](https://github.com/dotnet/runtime/blob/release/7.0/docs/project/library-servicing.md) and gotten it explicitly reviewed.

1 change: 0 additions & 1 deletion .github/workflows/check-service-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,3 @@ jobs:
else
exit 1
fi

23 changes: 21 additions & 2 deletions docs/project/library-servicing.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
# How to service a library

This document provides the steps necessary after modifying a library in a servicing branch (where "servicing branch" refers to any branch whose name begins with `release/`).
This document provides the steps necessary after modifying a library in a servicing branch.

Servicing branches represent shipped versions of .NET, and their name is in the format `release/X.0-staging`. Examples:

- `release/7.0-staging`
- `release/6.0-staging`

## Check if a package is generated

If a library is packable (check for the `<IsPackable>true</IsPackable>` property) you'll need to set `<GeneratePackageOnBuild>true</GeneratePackageOnBuild>` in the source project. That is necessary as packages aren't generated by default in servicing releases.

Additionally, if the library is listed among the project references of [Microsoft.Windows.Compatibility.csproj](https://github.com/dotnet/runtime/blob/43bb5993d4f983e9d575f52b691ecdc9b9e257ef/src/libraries/Microsoft.Windows.Compatibility/src/Microsoft.Windows.Compatibility.csproj#L15-L48), please make sure to bump the value of `ServicingVersion` for `Microsoft.Windows.Compatibility.csproj` and also set its `GeneratePackageOnBuild` property value to `true`. The version number must only be bumped once per servicing release, even if multiple dependencies get modified.

## Determine ServiceVersion

When you make a change to a library & ship it during the servicing release, the `ServicingVersion` must be bumped. This property is found in the library's source project. It's also possible that the property is not in that file, in which case you'll need to add it to the library's source project and set it to 1. If the property is already present in your library's source project, just increment the servicing version by 1.
Expand All @@ -23,4 +30,16 @@ All that's left is to ensure that your changes have worked as expected. To do so

## Approval Process

All the servicing change must go through an approval process. Please create your PR using [this template](https://raw.githubusercontent.com/dotnet/runtime/main/.github/PULL_REQUEST_TEMPLATE/servicing_pull_request_template.md). You should also add `servicing-consider` label to the pull request and bring it to the attention of the engineering lead responsible for the area.
All the servicing change must go through an approval process. You have two ways to submit your PR:

- By manually creating your PR using [this template](https://raw.githubusercontent.com/dotnet/runtime/main/.github/PULL_REQUEST_TEMPLATE/servicing_pull_request_template.md).
- Or by asking the bot to automatically create the servicing PR for you using a merged `main` PR as source. This method requires typing an AzDO backport command as a comment of your merged PR using the format `/backport to release/X.0-staging`. Examples:
-
- `/backport to release/7.0-staging`
- `/backport to release/6.0-staging`

For both cases, you must:

- Fill out the template of the PR description.
- Add the `servicing-consider` label.
- Bring it to the attention of the engineering lead responsible for the area, so they consider the fix for servicing.
64 changes: 32 additions & 32 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<Uri>https://github.com/dotnet/icu</Uri>
<Sha>8f5f53bc4ac6f86aa1f4044a5ec0095cfb231713</Sha>
</Dependency>
<Dependency Name="System.Net.MsQuic.Transport" Version="7.0.0-alpha.1.22406.1">
<Dependency Name="System.Net.MsQuic.Transport" Version="7.0.0-alpha.1.22459.1">
<Uri>https://github.com/dotnet/msquic</Uri>
<Sha>dc012a715ceb9b5d5258f2fda77520586af5a36a</Sha>
<Sha>b1a2104c42648101a2373a1278bcf4ef897ad840</Sha>
</Dependency>
<Dependency Name="System.ServiceModel.Primitives" Version="4.9.0-rc2.21473.1">
<Uri>https://github.com/dotnet/wcf</Uri>
Expand Down Expand Up @@ -130,57 +130,57 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>099bbb071e187ba4e1603004597624e6acae6394</Sha>
</Dependency>
<Dependency Name="System.ComponentModel.TypeConverter.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.ComponentModel.TypeConverter.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Data.Common.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Data.Common.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Drawing.Common.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Drawing.Common.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Formats.Tar.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Formats.Tar.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.IO.Compression.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.IO.Compression.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.IO.Packaging.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.IO.Packaging.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Net.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Net.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Private.Runtime.UnicodeData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Private.Runtime.UnicodeData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Runtime.TimeZoneData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Runtime.TimeZoneData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Security.Cryptography.X509Certificates.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Security.Cryptography.X509Certificates.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Text.RegularExpressions.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Text.RegularExpressions.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="System.Windows.Extensions.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Windows.Extensions.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.CilStrip.Sources" Version="7.0.0-beta.23151.1">
<Dependency Name="Microsoft.DotNet.CilStrip.Sources" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk" Version="11.1.0-alpha.1.23115.1">
<Uri>https://github.com/dotnet/llvm-project</Uri>
Expand Down Expand Up @@ -242,9 +242,9 @@
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>e680411c22e33f45821f4ae64365a2970b2430a6</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="7.0.100-1.22423.4">
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="7.0.100-1.23207.1">
<Uri>https://github.com/dotnet/linker</Uri>
<Sha>313671b195b1b36d56a8888a9a0e12edaac52c57</Sha>
<Sha>08a09f27f664fb84368aa4b9eb862b13bf808579</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XHarness.TestRunners.Common" Version="1.0.0-prerelease.22411.1">
<Uri>https://github.com/dotnet/xharness</Uri>
Expand Down Expand Up @@ -282,9 +282,9 @@
<Uri>https://github.com/dotnet/hotreload-utils</Uri>
<Sha>14a4f4c6e6478b84cac9037935f823b40ddad01d</Sha>
</Dependency>
<Dependency Name="System.Runtime.Numerics.TestData" Version="7.0.0-beta.23151.1">
<Dependency Name="System.Runtime.Numerics.TestData" Version="7.0.0-beta.23179.6">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>a2980bba169e946d9e1e77a3a73226ee6096998c</Sha>
<Sha>ec5d27d08b78d68d96eeb8899f329a2fa732923a</Sha>
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.0-preview1.22559.1">
<Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
Expand Down
32 changes: 16 additions & 16 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -118,20 +118,20 @@
<SystemValueTupleVersion>4.5.0</SystemValueTupleVersion>
<runtimenativeSystemIOPortsVersion>7.0.0-rc.1.22414.6</runtimenativeSystemIOPortsVersion>
<!-- Runtime-Assets dependencies -->
<SystemRuntimeNumericsTestDataVersion>7.0.0-beta.23151.1</SystemRuntimeNumericsTestDataVersion>
<SystemComponentModelTypeConverterTestDataVersion>7.0.0-beta.23151.1</SystemComponentModelTypeConverterTestDataVersion>
<SystemDataCommonTestDataVersion>7.0.0-beta.23151.1</SystemDataCommonTestDataVersion>
<SystemDrawingCommonTestDataVersion>7.0.0-beta.23151.1</SystemDrawingCommonTestDataVersion>
<SystemFormatsTarTestDataVersion>7.0.0-beta.23151.1</SystemFormatsTarTestDataVersion>
<SystemIOCompressionTestDataVersion>7.0.0-beta.23151.1</SystemIOCompressionTestDataVersion>
<SystemIOPackagingTestDataVersion>7.0.0-beta.23151.1</SystemIOPackagingTestDataVersion>
<SystemNetTestDataVersion>7.0.0-beta.23151.1</SystemNetTestDataVersion>
<SystemPrivateRuntimeUnicodeDataVersion>7.0.0-beta.23151.1</SystemPrivateRuntimeUnicodeDataVersion>
<SystemRuntimeTimeZoneDataVersion>7.0.0-beta.23151.1</SystemRuntimeTimeZoneDataVersion>
<SystemSecurityCryptographyX509CertificatesTestDataVersion>7.0.0-beta.23151.1</SystemSecurityCryptographyX509CertificatesTestDataVersion>
<SystemTextRegularExpressionsTestDataVersion>7.0.0-beta.23151.1</SystemTextRegularExpressionsTestDataVersion>
<SystemWindowsExtensionsTestDataVersion>7.0.0-beta.23151.1</SystemWindowsExtensionsTestDataVersion>
<MicrosoftDotNetCilStripSourcesVersion>7.0.0-beta.23151.1</MicrosoftDotNetCilStripSourcesVersion>
<SystemRuntimeNumericsTestDataVersion>7.0.0-beta.23179.6</SystemRuntimeNumericsTestDataVersion>
<SystemComponentModelTypeConverterTestDataVersion>7.0.0-beta.23179.6</SystemComponentModelTypeConverterTestDataVersion>
<SystemDataCommonTestDataVersion>7.0.0-beta.23179.6</SystemDataCommonTestDataVersion>
<SystemDrawingCommonTestDataVersion>7.0.0-beta.23179.6</SystemDrawingCommonTestDataVersion>
<SystemFormatsTarTestDataVersion>7.0.0-beta.23179.6</SystemFormatsTarTestDataVersion>
<SystemIOCompressionTestDataVersion>7.0.0-beta.23179.6</SystemIOCompressionTestDataVersion>
<SystemIOPackagingTestDataVersion>7.0.0-beta.23179.6</SystemIOPackagingTestDataVersion>
<SystemNetTestDataVersion>7.0.0-beta.23179.6</SystemNetTestDataVersion>
<SystemPrivateRuntimeUnicodeDataVersion>7.0.0-beta.23179.6</SystemPrivateRuntimeUnicodeDataVersion>
<SystemRuntimeTimeZoneDataVersion>7.0.0-beta.23179.6</SystemRuntimeTimeZoneDataVersion>
<SystemSecurityCryptographyX509CertificatesTestDataVersion>7.0.0-beta.23179.6</SystemSecurityCryptographyX509CertificatesTestDataVersion>
<SystemTextRegularExpressionsTestDataVersion>7.0.0-beta.23179.6</SystemTextRegularExpressionsTestDataVersion>
<SystemWindowsExtensionsTestDataVersion>7.0.0-beta.23179.6</SystemWindowsExtensionsTestDataVersion>
<MicrosoftDotNetCilStripSourcesVersion>7.0.0-beta.23179.6</MicrosoftDotNetCilStripSourcesVersion>
<!-- dotnet-optimization dependencies -->
<optimizationwindows_ntx64MIBCRuntimeVersion>1.0.0-prerelease.22415.6</optimizationwindows_ntx64MIBCRuntimeVersion>
<optimizationwindows_ntx86MIBCRuntimeVersion>1.0.0-prerelease.22415.6</optimizationwindows_ntx86MIBCRuntimeVersion>
Expand Down Expand Up @@ -174,13 +174,13 @@
<!-- Docs -->
<MicrosoftPrivateIntellisenseVersion>7.0.0-preview-20221010.1</MicrosoftPrivateIntellisenseVersion>
<!-- ILLink -->
<MicrosoftNETILLinkTasksVersion>7.0.100-1.22423.4</MicrosoftNETILLinkTasksVersion>
<MicrosoftNETILLinkTasksVersion>7.0.100-1.23207.1</MicrosoftNETILLinkTasksVersion>
<MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
<!-- ICU -->
<MicrosoftNETCoreRuntimeICUTransportVersion>7.0.0-rtm.23115.1</MicrosoftNETCoreRuntimeICUTransportVersion>
<!-- MsQuic -->
<MicrosoftNativeQuicMsQuicVersion>2.1.1</MicrosoftNativeQuicMsQuicVersion>
<SystemNetMsQuicTransportVersion>7.0.0-alpha.1.22406.1</SystemNetMsQuicTransportVersion>
<SystemNetMsQuicTransportVersion>7.0.0-alpha.1.22459.1</SystemNetMsQuicTransportVersion>
<!-- Mono LLVM -->
<runtimelinuxarm64MicrosoftNETCoreRuntimeMonoLLVMSdkVersion>11.1.0-alpha.1.23115.1</runtimelinuxarm64MicrosoftNETCoreRuntimeMonoLLVMSdkVersion>
<runtimelinuxarm64MicrosoftNETCoreRuntimeMonoLLVMToolsVersion>11.1.0-alpha.1.23115.1</runtimelinuxarm64MicrosoftNETCoreRuntimeMonoLLVMToolsVersion>
Expand Down
2 changes: 1 addition & 1 deletion eng/packaging.targets
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<_IsWindowsDesktopApp Condition="$(WindowsDesktopCoreAppLibrary.Contains('$(AssemblyName);'))">true</_IsWindowsDesktopApp>
<_IsAspNetCoreApp Condition="$(AspNetCoreAppLibrary.Contains('$(AssemblyName);'))">true</_IsAspNetCoreApp>
<_AssemblyInTargetingPack Condition="('$(IsNETCoreAppSrc)' == 'true' or '$(IsNetCoreAppRef)' == 'true' or '$(_IsAspNetCoreApp)' == 'true' or '$(_IsWindowsDesktopApp)' == 'true') and '$(TargetFrameworkIdentifier)' != '.NETFramework'">true</_AssemblyInTargetingPack>
<!-- Assembly version do not get updated in non-netfx ref pack assemblies. -->
<!-- The assembly version gets updated when the assembly isn't part of a targeting pack. -->
<AssemblyVersion Condition="'$(_AssemblyInTargetingPack)' != 'true'">$(MajorVersion).$(MinorVersion).0.$(ServicingVersion)</AssemblyVersion>
</PropertyGroup>

Expand Down
10 changes: 5 additions & 5 deletions eng/pipelines/libraries/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ jobs:

# tvOS devices
- ${{ if in(parameters.platform, 'tvOS_arm64') }}:
# split traffic for runtime-extra-platforms (which mostly runs on rolling builds)
# if necessary, you can split traffic between queues this way for PR's and rolling builds
- ${{ if ne(parameters.jobParameters.isExtraPlatforms, true) }}:
- OSX.1015.Amd64.AppleTV.Open
- OSX.13.Amd64.AppleTV.Open
- ${{ if eq(parameters.jobParameters.isExtraPlatforms, true) }}:
- OSX.1100.Amd64.AppleTV.Open
- OSX.13.Amd64.AppleTV.Open

# windows x64
- ${{ if eq(parameters.platform, 'windows_x64') }}:
Expand All @@ -144,7 +144,7 @@ jobs:
- (Windows.10.Amd64.ServerRS5.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2019-helix-amd64
- ${{ if or(ne(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.81.Amd64.Open
- Windows.10.Amd64.Server2022.ES.Open
- Windows.Amd64.Server2022.Open
- Windows.11.Amd64.Client.Open
- ${{ if eq(parameters.jobParameters.testScope, 'outerloop') }}:
- (Windows.10.Amd64.ServerRS5.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2019-helix-amd64
Expand All @@ -170,7 +170,7 @@ jobs:
- Windows.11.Amd64.Client.Open
- Windows.Amd64.Server2022.Open
- ${{ if or(ne(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.10.Amd64.Server2022.ES.Open
- Windows.Amd64.Server2022.Open
- Windows.7.Amd64.Open

# .NETFramework
Expand Down
2 changes: 2 additions & 0 deletions eng/testing/tests.android.targets
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
DestinationFolder="$(TestArchiveTestsDir)"
SkipUnchangedFiles="true"
Condition="'$(ArchiveTests)' == 'true' and '$(IgnoreForCI)' != 'true'" />

<RemoveDir Condition="'$(ArchiveTests)' == 'true' and '$(AndroidGenerateAppBundle)' == 'true'" Directories="$(OutDir)" />
</Target>

</Project>
10 changes: 9 additions & 1 deletion src/coreclr/gc/gc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28792,7 +28792,8 @@ void gc_heap::process_remaining_regions (int current_plan_gen_num, generation* c
return;
}

set_region_plan_gen_num_sip (current_region, current_plan_gen_num);
decide_on_demotion_pin_surv (current_region);

if (!heap_segment_swept_in_plan (current_region))
{
heap_segment_plan_allocated (current_region) = generation_allocation_pointer (consing_gen);
Expand Down Expand Up @@ -30515,6 +30516,13 @@ void gc_heap::plan_phase (int condemned_gen_number)
gc_time_info[time_plan] = gc_time_info[time_sweep] - gc_time_info[time_plan];
}
#endif //FEATURE_EVENT_TRACE

#ifdef USE_REGIONS
if (special_sweep_p)
{
should_compact = FALSE;
}
#endif //!USE_REGIONS
#endif //MULTIPLE_HEAPS

#ifdef FEATURE_LOH_COMPACTION
Expand Down
Loading