Disable nullability checks in file shared between the managed type system and ILVerificationTests #84382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem and ILVerificationTests This file is shared between the managed type system and the ILVerificationTests suite. The managed type system doesn't have nullable checks turned on, but ILVerificationTests does. This was causing build failures in PRs that build the ILVerificationTests. We should enable nullable checking in the future in the managed type system as a whole at some point, but we aren't there yet.
jkoritzinsky
added
the
area-Tools-ILVerification
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is shared between the managed type system and the ILVerificationTests suite. The managed type system doesn't have nullable checks turned on, but ILVerificationTests does. This was causing build failures in PRs that build the ILVerificationTests.
We should enable nullable checking in the future in the managed type system as a whole at some point, but we aren't there yet.
Fixes build failures seen in https://dev.azure.com/dnceng-public/public/_build/results?buildId=228970&view=logs&jobId=b6bdb2f4-3eb6-55c8-85cc-95fa9acdf5c2&j=b6bdb2f4-3eb6-55c8-85cc-95fa9acdf5c2&t=17583d34-54f0-5e12-5308-7a4c567d6cc1