Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Free up more disk space on CI builds #84354

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

steveisok
Copy link
Member

@steveisok steveisok commented Apr 5, 2023

The android builds are running out of disk space when building the library test apps. This change tries to recoup some of that space by deleting artifacts after each test was built.

Addresses dotnet/arcade#13036

The android builds are running out of disk space when building the library test apps.  This change tries to recoup some of that space by deleting artifacts after each test was built.
@ghost
Copy link

ghost commented Apr 5, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

The android builds are running out of disk space when building the library test apps. This change tries to recoup some of that space by deleting artifacts after each test was built.

Author: steveisok
Assignees: steveisok
Labels:

area-Infrastructure-mono

Milestone: -

@steveisok
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 84354 in repo dotnet/runtime

@steveisok
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -14,6 +14,8 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\..\TestAssets\StartupHookForFunctionalTest\StartupHookForFunctionalTest.csproj" />
<ProjectReference Include="..\..\..\TestAssets\StartupHookForFunctionalTest\StartupHookForFunctionalTest.csproj">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem trivial to get working at the moment, should we just disable this test so we can atleast have coverage for all other tests?

@steveisok
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok steveisok merged commit 2c37a2d into dotnet:main Apr 5, 2023
@steveisok
Copy link
Member Author

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4623465416

@steveisok
Copy link
Member Author

/backport to release/6.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/4623467456

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

@steveisok backporting to release/7.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [Android] Free up more disk space on CI builds
Applying: Fix startuphook test.
Using index info to reconstruct a base tree...
A	src/tests/FunctionalTests/Android/Device_Emulator/StartupHook/Android.Device_Emulator.StartupHook.Test.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/tests/FunctionalTests/Android/Device_Emulator/InvariantCultureOnlyMode/Android.Device_Emulator.InvariantCultureOnlyMode.Test.csproj
CONFLICT (content): Merge conflict in src/tests/FunctionalTests/Android/Device_Emulator/InvariantCultureOnlyMode/Android.Device_Emulator.InvariantCultureOnlyMode.Test.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix startuphook test.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

@steveisok an error occurred while backporting to release/7.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

@steveisok backporting to release/6.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [Android] Free up more disk space on CI builds
Using index info to reconstruct a base tree...
A	eng/testing/tests.android.targets
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): eng/testing/tests.android.targets deleted in HEAD and modified in [Android] Free up more disk space on CI builds. Version [Android] Free up more disk space on CI builds of eng/testing/tests.android.targets left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [Android] Free up more disk space on CI builds
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

@steveisok an error occurred while backporting to release/6.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

steveisok pushed a commit to steveisok/runtime that referenced this pull request Apr 10, 2023
backport of dotnet#84354

The android builds are running out of disk space when building the library test apps. This change tries to recoup some of that space by deleting artifacts after each test was built.
steveisok pushed a commit to steveisok/runtime that referenced this pull request Apr 10, 2023
backport of dotnet#84354

The android builds are running out of disk space when building the library test apps. This change tries to recoup some of that space by deleting artifacts after each test was built.
carlossanlop pushed a commit that referenced this pull request Apr 10, 2023
backport of #84354

The android builds are running out of disk space when building the library test apps. This change tries to recoup some of that space by deleting artifacts after each test was built.

Co-authored-by: Steve Pfister <[email protected]>
carlossanlop pushed a commit that referenced this pull request Apr 10, 2023
backport of #84354

The android builds are running out of disk space when building the library test apps. This change tries to recoup some of that space by deleting artifacts after each test was built.

Co-authored-by: Steve Pfister <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants