Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CodeAnalysis.src.globalconfig #84059

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Update CodeAnalysis.src.globalconfig #84059

merged 1 commit into from
Apr 15, 2023

Conversation

stephentoub
Copy link
Member

  • Update the names of rules to match the current ones defined in NetAnalyzers
  • Add a few more IDE rules, including enabling IDE0280 Use nameof

@ghost ghost assigned stephentoub Mar 29, 2023
@ghost
Copy link

ghost commented Mar 29, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Update the names of rules to match the current ones defined in NetAnalyzers
  • Add a few more IDE rules, including enabling IDE0280 Use nameof
Author: stephentoub
Assignees: -
Labels:

area-Meta
Milestone: -

buyaa-n
buyaa-n approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there is build failures caused by IDE0280, otherwise LGTM.

@build-analysis build-analysis bot mentioned this pull request Mar 30, 2023
Closed
@stephentoub stephentoub closed this Apr 1, 2023
@stephentoub stephentoub reopened this Apr 1, 2023
This was referenced Apr 6, 2023
Closed
Open
Closed
@stephentoub
Update CodeAnalysis.src.globalconfig
0bbe8ed 
- Update the names of rules to match the current ones defined in NetAnalyzers
- Add a few more IDE rules, including enabling `IDE0280 Use nameof`
@build-analysis build-analysis bot mentioned this pull request Apr 15, 2023
Closed
@stephentoub
Copy link
Member Author

Failures are the known wasm issues impacting practically all PRs.

@stephentoub stephentoub merged commit ba777a8 into dotnet:main Apr 15, 2023
@stephentoub stephentoub deleted the caupdate branch April 15, 2023 20:59
@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@stephentoub stephentoub

Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephentoub @buyaa-n