Restore original stack ref enumeration behavior #84034
Conversation
The previous change to ICorDebugGCReferenceEnum accidently inverted the logic for interior pointers.
ghost
assigned
|
Tagging subscribers to this area: @tommcdon Issue DetailsThe previous change to ICorDebugGCReferenceEnum accidently inverted the logic for interior pointers.
|
| { | ||
| stackRefs[i].i64ExtraData = GC_CALL_INTERIOR; | ||
| stackRefs[i].objHnd.SetDacTargetPtr(CLRDATA_ADDRESS_TO_TADDR(sosStackRef.Address)); | ||
| stackRefs[i].pObject = CLRDATA_ADDRESS_TO_TADDR(sosStackRef.Object) | 1; |
There was a problem hiding this comment.
So i64ExtraData no longer needs to be set to GC_CALL_INTERIOR in this branch?
There was a problem hiding this comment.
The original behavior was that i64ExtraData was always set to 0, for all kinds of stack pointers. (It probably should be set, but it's not.) Setting it to 0 in both cases just makes sure we preserve the previous behavior that VS might have taken a dependency on.
I'm solving this a different way in the upcoming change to improve performance. (That PR will come later, after VS takes a look at it.)
2 participants
The previous change to ICorDebugGCReferenceEnum accidently inverted the logic for interior pointers.