Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade arm64 cross image to Ubuntu 22.04 / llvm-15 #83939

Closed
wants to merge 2 commits into from

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 26, 2023

This image is based on Ubuntu 22.04 instead of 20.04 with llvm-15 toolchain instead of llvm-9 in the host layer. It has the same Ubuntu 16.04 (which we lowered in #80939) in /crossrootfs dir. See dotnet/dotnet-buildtools-prereqs-docker#815.

llvm9 has a bug in llvm-objcopy which causes the size regression (#49081), it was fixed in llvm10. That means we can bring crossgen2's NativeAOT linux-arm64 publishing to the same plan as linux-musl-arm64 with this update. Hence the change in sfxproj.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 26, 2023
@ghost
Copy link

ghost commented Mar 26, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This image is based on Ubuntu 22.04 instead of 20.04 with llvm-15 toolchain instead of llvm-9 in the host layer. It has the same Ubuntu 16.04 (which we lowered in #80939) in /crossrootfs dir. See dotnet/dotnet-buildtools-prereqs-docker#815.

llvm9 has a bug in llvm-objcopy which causes the size regression (#49081), which was fixed in llvm10. Which means, we can bring crossgen2's NativeAOT linux-arm64 publishing to the same plan as linux-musl-arm64 with this update. Hence the change in sfxproj.

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

@am11 am11 force-pushed the feature/build/arm64-cross-image branch from 0cf8e0c to 83aa27a Compare March 26, 2023 09:45
@am11 am11 marked this pull request as ready for review March 26, 2023 12:17
@sbomer
Copy link
Member

sbomer commented Apr 17, 2023

@am11 I think we can close this now that #84148 has made it in.

@am11
Copy link
Member Author

am11 commented Apr 18, 2023

Yes, this is no longer needed. We can also delete dotnet-buildtools-prereqs-docker/src/ubuntu/20.04/cross/arm64 /Dockerfile since this was the last consumer.

@am11 am11 closed this Apr 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants