-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Update dependencies from dotnet/xharness #83829
[release/6.0] Update dependencies from dotnet/xharness #83829
Conversation
…30313.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.21404.1 -> To Version 1.0.0-prerelease.23163.1
This PR hit a lot of failures. The known issues were all linked above by the bot. I did find a new issue. @lewing @steveisok @radical is this issue related to the current PR? If not, let me know and I can open an issue for it.
|
That is a new one to me but this is a huge delta from the previous xharness in 6.0 so I'm not really surprised there are issues? |
@premun @akoeplinger are there extras in runtime we need to accompany this? |
Sorry for the noise. @hoyosjs and I saw a weird behavior in the new label check and were investigating by changing the branch. |
I don't have much knowledge about the WASM parts of XHarness. I don't think there's anything else needed but also no idea what is this |
Afaik, we don't really need this update for anything worthwhile |
Yeah, that's probably a good idea |
The only thing would be the mlaunch bump in xharness since I believe that was needed for recent Xcode versions. RemoteLoopServer is coming from the runtime repo, see https://github.com/dotnet/runtime/tree/main/src/libraries/Common/tests/System/Net/Prerequisites/RemoteLoopServer. We might want to branch xharness as well so we could just cherry-pick fixes like the mlaunch bump. |
Yeah, branching XHarness is probably the right thing to do. I created dotnet/xharness#1010 and can take care of this |
Per the conversation above, I have disabled runtime's darc subscriptions to xharness in both 6.0 and 7.0, so we can now close the PR. |
This pull request updates the following dependencies
From https://github.com/dotnet/xharness