[mono][jit] Add vector horizontal sums and ToScalar on arm64. #83675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their generalized variants. Added OP_EXTRACTx opcodes to arm64 codegen. Added horizontal sums.
vargaz
reviewed
Mar 20, 2023
src/mono/mono/mini/mini-arm64.c
Outdated
| @@ -3715,6 +3723,57 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb) | |||
| case OP_XCAST: | |||
| break; | |||
|
|
|||
|
|
|||
vargaz
reviewed
Mar 20, 2023
src/mono/mono/mini/mini-arm64.c
Outdated
| case OP_EXTRACT_R4: | ||
| case OP_EXTRACT_R8: | ||
| if (ins->dreg != ins->sreg1 || ins->inst_c0 != 0) { | ||
| const int t = get_type_size_macro (ins->inst_c1); |
vargaz
approved these changes
Mar 20, 2023
This was referenced Mar 20, 2023
src/mono/mono/mini/simd-intrinsics.c
Outdated
| @@ -1908,6 +1917,7 @@ emit_vector64_vector128_t (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSign | |||
| case SN_op_BitwiseAnd: | |||
| case SN_op_BitwiseOr: | |||
| case SN_op_ExclusiveOr: | |||
| case SN_Sum: | |||
There was a problem hiding this comment.
This is not needed, as Sum is not one of the API's of vector128_t. vector64_vector128_t_methods contains all possible API's of vector128_t.
jandupej
changed the title
This was referenced Mar 28, 2023
Closed
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
OP_EXTRACT*on arm64. The case when extracting the first float/double element into the first register is optimized out. Added support forOP_ARM64_XADDVto mini JIT. These facilitate handlingSN_Sum, which results fromVector128<T>.Sum.Necessary instruction emit macros were added and fixed.
EDIT: This also adds
ToScalar, since it is easily implemented withOP_EXTRACT*.Contributes to #80566