[mono] Allow a single call when inlining methods #83548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y possible to inline List.get_Item
kg
changed the title
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsThis combined with #83490 would allow inlining List.get_Item, since it contains a single call to a ThrowHelper.
|
|
Doesn't work right because I need to save/restore the TransformData flag when inlining, I think. Looking into it. |
kg
added
the
NO-MERGE
…hods Don't allow doesnotreturn method calls to disable inlining, since we know they are unlikely to be called
kg
removed
the
NO-MERGE
|
Fixed it, should be ready for review now. In my testing it takes the V8.Crypto benchmark from dotnet/performance down to ~180ms from a baseline of 260-280ms. EDIT: Previous measurement (~80ms) was combined with #83490, this by itself is ~180ms |
vargaz
approved these changes
Mar 16, 2023
This was referenced Mar 17, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combined with #83490 would allow inlining List.get_Item, since it contains a single call to a ThrowHelper.
DoesNotReturn method calls also no longer prohibit inlining, which will help for methods that call ThrowHelper in a never-taken* branch and then make a single call that does actual work.