-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Remove VersionSuffix from servicing builds #83326
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #83311. Customer ImpactIn servicing, we don't append version suffix to the Product Version. This centralized fix is applied to all shipping components alike. Currently, we only omit suffix in some assemblies like TestingManual testing using RiskLow.
|
Do you know why there is a behavior difference here between CoreLib and other assemblies? In general, do you feel strongly about backporting this change? I haven't heard any customer complains yet and I wonder if we need to backport this if it's just for cosmetic reasons. |
@@ -38,6 +38,7 @@ | |||
<Product>Microsoft%AE .NET</Product> | |||
<!-- Use the .NET product branding version for informational version description --> | |||
<InformationalVersion Condition="'$(InformationalVersion)' == '' and '$(VersionSuffix)' == ''">$(ProductVersion)</InformationalVersion> | |||
<InformationalVersion Condition="'$(InformationalVersion)' == '' and '$(PreReleaseVersionLabel)' == 'servicing'">$(ProductVersion)</InformationalVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why VersionSuffix
is even set during servicing builds? Arcade unsets it here: https://github.com/dotnet/arcade/blob/cb64095ec45ac34378a1a26db9932a3b561f9e4e/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L85-L90
Discussed this with @ViktorHofer offline - If we decide to take this, we would like it to go into the May release. |
Not a sufficient impact to address in a short-lived servicing release. |
Backport of #83311.
Customer Impact
In servicing, we don't append version suffix to the Product Version. This centralized fix is applied to all shipping components alike. Currently, we only omit suffix in some assemblies like
System.Private.CoreLib.dll
but not crossgen2.dll etc.Testing
Manual testing using
./build.sh clr+libs+packs -ci -p:OfficialBuildId=22606.5
to make sure that VersionSuffix isn't added to the Product Version of crossgen2; which is reported bycrossgen2 --version
.Risk
Low.