[6.0] Fix intellisense xml file selection from 'net' or 'dotnet-plat-ext' #82562
Conversation
…tifacts/bin/docs copy.
…r the 'net' or the 'dotnet-plat-ext' folder when packaging.
carlossanlop
requested review from
jeffhandley,
ViktorHofer,
ericstj and
smasher164
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsAddresses the 6.0 bug of #82214 There are two places in 6.0 where the intellisense xml files are analyzed and/or copied. In packaging.targets, we decide if we want to include in the assembly package either the built xml or the one that comes from the internal intellisense nupkg. If we decide to use the latter, we were missing logic that would find the right xml file in either the 'net' or the 'dotnet-plat-ext' folder of the extracted nupkg. Instead, we were only looking inside 'net', and assemblies like System.IO.Ports were not getting anything included in its nupkg. In docs.targets, we were only copying to artifacts/bin/docs the files that were found in the 'net' folder of the internal intellisense nupkg. We need to also copy the files from 'dotnet-plat-ext', so that assemblies like System.IO.Ports get the right documentation shipped. cc @krwq
|
|
Failures unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Addresses the 6.0 bug of #82214
There are two places in 6.0 where the intellisense xml files are analyzed and/or copied.
In packaging.targets, we decide if we want to include in the assembly package either the built xml or the one that comes from the internal intellisense nupkg. If we decide to use the latter, we were missing logic that would find the right xml file in either the 'net' or the 'dotnet-plat-ext' folder of the extracted nupkg. Instead, we were only looking inside 'net', and assemblies like System.IO.Ports were not getting anything included in its nupkg.
In docs.targets, we were only copying to artifacts/bin/docs the files that were found in the 'net' folder of the internal intellisense nupkg. We need to also copy the files from 'dotnet-plat-ext', so that assemblies like System.IO.Ports get the right documentation shipped.
cc @krwq