Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mariner Linux image to 2.0 #81973

Merged
merged 8 commits into from
Mar 20, 2023
Merged

update mariner Linux image to 2.0 #81973

merged 8 commits into from
Mar 20, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 10, 2023

MsQuic now works on Centos 7 & Mariner 2.0
(fix for microsoft/msquic#3422 rolled into 2.1.8)

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-81973-merge-808ab19800c3444c99/System.Net.Quic.Functional.Tests/1/console.0eaba122.log

Console log: 'System.Net.Quic.Functional.Tests' from job 808ab198-00c3-444c-9983-c24f3929b683 (ubuntu.1804.amd64.open.rt) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-helix-amd64 on a00A27U


----- start Fri Mar 17 18:44:21 UTC 2023 =============== To repro directly: =====================================================
pushd .
/root/helix/work/correlation/dotnet exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 113 of 122 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 337, Errors: 0, Failed: 0, Skipped: 1, Time: 89.975s
/root/helix/work/workitem/e

fixes #81901

@ghost
Copy link

ghost commented Feb 10, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

PoC

Author: wfurt
Assignees: wfurt
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Feb 10, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

PoC

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

@wfurt wfurt added os-linux Linux OS (any supported distro) os-mariner CBL Mariner labels Feb 10, 2023
@wfurt
Copy link
Member Author

wfurt commented Feb 10, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

@wfurt Friendly reminder that all RID changes that we want to include in the March Servicing Release need to be backported to 6.0 and 7.0 by tomorrow, which is the Code Complete day.

cc @mmitche @rbhanda

@wfurt wfurt marked this pull request as ready for review March 17, 2023 20:59
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :shipit:

@wfurt
Copy link
Member Author

wfurt commented Mar 20, 2023

Xml test failures are unrelated.

@wfurt wfurt merged commit 850a320 into dotnet:main Mar 20, 2023
@wfurt wfurt deleted the mariner branch March 20, 2023 19:23
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic os-linux Linux OS (any supported distro) os-mariner CBL Mariner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUIC] Missing libmsquic on tested platforms
4 participants