-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for FreeBSD arm64 w/NativeAOT #81510
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBased on 70e1072 this PR adds same things for arm64 host. I was using
|
FreeBSD x64 exhibits the same issue under LLVM/Clang15
Would this fix only apply to ld.lld 13 or higher? |
We added |
Thanks - adding this seems to work fine with the build. does this PR makes sense to merge, as it's adding some RIDs for arm64 same way x64 was added then? |
@sec, I think it would be fine to change the defaults for FreeBSD with:
in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
I think it is a good idea. It can be done as a new PR. |
Based on 70e1072 this PR adds same things for arm64 host.
With those changes runtime is able to build fine under FreeBSD arm64 host (there is some manual patching required with ObjWriter and UseHardlinksIfPossible property set to false on two targets and BinPlaceUseHardlinksIfPossible=false).
I was using
clang14
and needed to pass extra-z nostart-stop-gc
to make the build pass for crossgen2 (reading https://lld.llvm.org/ELF/start-stop-gc looks like that change was done starting from 13) - if this should be handled in diffrent way, let me know.@Thefrank @janvorli @am11