Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support targeting iOS platforms with ILCompiler #81476

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Feb 1, 2023

This PR enables ILCompiler to target iOS and iOSSimulator platforms.

It has been tested against a private branch which includes changes that enable building NativeAOT for iOS platforms.

/cc: @dotnet/ilc-contrib

@ivanpovazan ivanpovazan added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 1, 2023
@ghost ghost assigned ivanpovazan Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a work-in-progress PR of enabling ILCompiler to target iOS and iOSSimulator platforms.

It is being tested against a private branch which includes changes that enable building NativeAOT for iOS platforms.

/cc: https://github.com/orgs/dotnet/teams/ilc-contrib

Author: ivanpovazan
Assignees: -
Labels:

NO-MERGE, area-NativeAOT-coreclr

Milestone: -

@filipnavara
Copy link
Member

Btw, this line will likely need to be updated once this lands.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a reason why you have marked it as NO-MERGE?

@ivanpovazan
Copy link
Member Author

LGTM. Is there a reason why you have marked it as NO-MERGE?

@jkotas, I thought of waiting for the dependent issue (from the PR's description) to be closed first.

@jkotas
Copy link
Member

jkotas commented Feb 2, 2023

@jkotas, I thought of waiting for the dependent issue (from the PR's description) to be closed first.

I do not think we need to wait for the other issue to be closed. This PR looks good to me as-is.

@filipnavara
Copy link
Member

I do not think we need to wait for the other issue to be closed

+1. This unblocks some work in other repositories.

@ivanpovazan ivanpovazan removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 2, 2023
@ivanpovazan ivanpovazan marked this pull request as ready for review February 2, 2023 16:10
@ivanpovazan ivanpovazan changed the title WIP: Support targeting iOS platforms with ILCompiler Support targeting iOS platforms with ILCompiler Feb 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support targeting iOS platforms with ILCompiler
7 participants