Run nativeaot tests in helix #81439
Run nativeaot tests in helix #81439
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsnull
|
|
Hm, not sure how this works. Weren't we already running the smoke tests on the build machine? Does this disable that run? Or just add a new one? |
|
(nvm didn't notice this was a draft) |
- buildConfig casing - Support uniform test filter syntax for bash/cmd - Remove problematic quotes from testFilter argument
And remove broken os arg. Also clean up: - release config comment - use of platform-specific test filter
- Pass args not recognized by build.cmd last - Make native exe executable on unix
- Replace existing nativeaot smoke test jobs with helix versions - Move BuildNativeAotFrameworkObjects out to runtime.yml, and only pass it for checked windows job. - Use nativeaot-post-build-steps to continue building nativeaot test apps
Also clean up name suffixes
This reverts commit 967c7ac.
| displayName: Build Tests | ||
|
|
||
| - ${{ if ne(parameters.runtimeFlavor, 'mono') }}: | ||
| - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) /p:LibrariesConfiguration=${{ parameters.buildConfig }} -ci os ${{ parameters.osGroup }} ${{ parameters.archType }} $(buildConfigUpper) | ||
| - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) ${{ parameters.archType }} $(buildConfigUpper) ${{ parameters.testBuildArgs }} -ci |
There was a problem hiding this comment.
Why don't we need the LibrariesConfiguration in this case?
There was a problem hiding this comment.
We don't want to use the buildConfig because libraries are always built in the Release configuration (the default) for these legs. If we ever want to use these templates with different libraries config, it's easy to add a parameter (I just didn't want to do it here to avoid changing the mono build legs).
- Remove unnecessary parameters - Clean up nameSuffix
This changes the existing NativeAot smoke test runs to run in helix. I changed the multi-module test run (only supported on windows) to run only in the checked configuration, to avoid having to add a separate windows build script invocation inside one of the yaml templates.