[release/7.0] [mono][aot] Disable dedup for wrapper with a return type which has a … #81003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…cmod. The wrappers are not found at runtime in some cases. Ref: #79814.
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
rbhanda
added
Servicing-approved
steveisok
approved these changes
Feb 8, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #80279 to release/7.0
/cc @lewing @vargaz
Customer Impact
This fixes a customer reported issue #79152 by not deduplicating a wrapper when the return type has a customer modifier.
Testing
Manual. We also verified the fix in CI tests but we don't test this configuration as part of the normal CI flow
Risk
Very low, impacted code path isn't enabled by default in net7.0 and the proposed change is simply skipping an invalid size optimization.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.