[mono][interp] Add 16 byte default alignment to interp frames #80700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue Detailsnull
|
BrzVlad
force-pushed
the
feature-interp-stack-alignment
branch
from
f841667
to
744b602
Compare
It serves no purpose nowadays. All vars are aligned to MINT_STACK_SLOT_SIZE.
BrzVlad
force-pushed
the
feature-interp-stack-alignment
branch
from
744b602
to
bb7dc9e
Compare
BrzVlad
force-pushed
the
feature-interp-stack-alignment
branch
from
bb7dc9e
to
21a6508
Compare
vargaz
approved these changes
Jan 17, 2023
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This will enable us to control alignment of Vector128 vars at compile time.
For normal calls, we introduce a new opcode before the call that will move all the arguments to aligned stack location. When emitting the code for the call, we emit directly the aligned call args offset instead. Unoptimized code has its own opcodes that do moving of param, we tweak them to copy them into aligned location.
BrzVlad
force-pushed
the
feature-interp-stack-alignment
branch
from
21a6508
to
6f57e7d
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support correct alignment for SIMD types (Vector128) in the future.