Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize RepoRoot path to improve logs readability #80664

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Jan 15, 2023

  • Normalize RepoRoot path in various batch scripts.
  • Use consistent style in those scripts which is used in build-runtime, src/tests/build and src/tests/run.
  • Quote paths.

e.g. before the CI:

BUILD: Product binaries are available at D:\a\_work\1\s\src\coreclr\..\..\artifacts\bin\coreclr\windows.x64.Checked

PR will normalize that path as:

BUILD: Product binaries are available at D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 15, 2023
@ghost
Copy link

ghost commented Jan 15, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Normalize RepoRoot path in various batch scripts.
  • Use consistent style in those scripts which is used in build-runtime, src/tests/build and src/tests/run.
  • Quote paths.

e.g. before the CI:

BUILD: Product binaries are available at D:\a\_work\1\s\src\coreclr\..\..\artifacts\bin\coreclr\windows.x64.Checked

PR will normalize that path as:

BUILD: Product binaries are available at D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked
Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution

Milestone: -

@ghost
Copy link

ghost commented Jan 15, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Normalize RepoRoot path in various batch scripts.
  • Use consistent style in those scripts which is used in build-runtime, src/tests/build and src/tests/run.
  • Quote paths.

e.g. before the CI:

BUILD: Product binaries are available at D:\a\_work\1\s\src\coreclr\..\..\artifacts\bin\coreclr\windows.x64.Checked

PR will normalize that path as:

BUILD: Product binaries are available at D:\a\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked
Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

@am11 am11 requested a review from jkotas January 15, 2023 10:16
@am11
Copy link
Member Author

am11 commented Jan 15, 2023

Failures are unrelated #78454, #73721 etc.

@@ -11,8 +11,10 @@ if %argC% lss 4 GOTO :USAGE
if %1=="/?" GOTO :USAGE

setlocal enabledelayedexpansion
set basePath=%~dp0
set __repoRoot=%~dp0..\..\
set "basePath=%~dp0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basePath does not seems to be used anywhere. Delete it?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dotnet/runtime-infrastructure Any additional feedback?

@akoeplinger akoeplinger merged commit 852fcbd into dotnet:main Jan 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants